Add plain arg to account banner#460
Merged
Merged
Conversation
Elodie-DeMatteis-Upf
requested review from
aprentout and
edouardmisset
and removed request for
a team
JulienVannier66
approved these changes
Apr 8, 2026
olxmpe
reviewed
Apr 8, 2026
| await render(hbs`<Utils::AccountBanner @subtitle="subtitle" />`); | ||
|
|
||
| assert.dom('[data-control-name="account-banner-selected-item-label"]').containsText('subtitle'); | ||
| assert.dom('[data-control-name="account-banner-selected-item-label"]').hasText('subtitle *'); |
Contributor
There was a problem hiding this comment.
There shouldn't be a space before *, no ?
phndiaye
reviewed
Apr 9, 2026
| } | ||
|
|
||
| &--plain { | ||
| .bg-color-white; |
Member
There was a problem hiding this comment.
this class exists? thought it was background-color-white in oss-components 🤔
Base automatically changed from
jv/vel-7480/handle-account-selection-from-payment-apps-side-panel-form-validation
to
feature/multi-currency
April 10, 2026 12:50
JulienVannier66
force-pushed
the
edm/add-plain-arg
branch
from
b9a8f2e to
72f5aeb
Compare
JulienVannier66
force-pushed
the
edm/add-plain-arg
branch
from
72f5aeb to
3d4a559
Compare
phndiaye
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add plain arg to account banner to allow for a white background style
Related to: #
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist