Add form validation to AccountBanner for account selection#461
Merged
Conversation
Elodie-DeMatteis-Upf
approved these changes
Apr 3, 2026
olxmpe
reviewed
Apr 7, 2026
Contributor
There was a problem hiding this comment.
You showed me how it works (and it works perfectly), but I still think it's really weird to put an OSS::Form here. Couldn't we just pass a “required” flag and and a feedback message as arguments and handle the form logic in the parent component, where register-form-field would be used on the account-banner component instead ?
olxmpe
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add form validation logic to the
Utils::AccountBannercomponent to handle account selection from the side panel.OSS::Formin the subtitle area to register a required form field (account.select)*) and validation modifiers based on@selectedAccountpresence@onFormSetupcallback so consumers can access the form instance@selectedAccountand form errorsWhat are the observable changes?
Screencast.from.2026-04-02.17-31-05.webm
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist