Feature flag the following features: manage fields, filters reset, column filtering#238
Merged
Conversation
phndiaye
requested review from
OwenCoogan,
aprentout and
olxmpe
and removed request for
a team
JulienVannier66
approved these changes
Apr 3, 2025
Elodie-DeMatteis-Upf
approved these changes
Apr 3, 2025
| type FeatureSet = { | ||
| selection: boolean; | ||
| searchable: boolean; | ||
| manageable_fields: boolean; |
Contributor
There was a problem hiding this comment.
I'm not sure what's the use of the feature flags? Is it to enable/disable one or another part of the feature?
aprentout
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Feature flag the following features: manage fields, filters reset, column filtering.
This will allow us to unlock more usages of the table where the parent apps want more control on the filtering behaviours by opting-out of the default UX.
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes