Fixes for FeatureCardsContainer component#664
Merged
Conversation
Miexil
commented
May 4, 2026
|
|
||
| if (cardsCount === 2 || cardsCount === 3) return index === 0 ? 'blue' : 'yellow'; | ||
|
|
||
| assert('[OSS::FeatureCardsContainer] Internal layout configuration mismatch', false); |
Member
Author
There was a problem hiding this comment.
Removed assertion here and on line 27 as we already check in the constructor if we have 1,2 or 3 cards. This code is unreachable.
aprentout
approved these changes
May 4, 2026
JulienVannier66
approved these changes
May 4, 2026
Miexil
commented
May 5, 2026
| @@ -1 +1 @@ | |||
| @import url('https://fonts.googleapis.com/css?family=Reddit+Sans:wght@400&family=Open+Sans:400,400i,600,600i,700,700i&display=swap&subset=cyrillic,cyrillic-ext,greek,greek-ext,latin-ext,vietnamese'); | |||
| @import url('https://fonts.googleapis.com/css?family=Reddit+Sans:wght@400,600&family=Open+Sans:400,400i,600,600i,700,700i&display=swap&subset=cyrillic,cyrillic-ext,greek,greek-ext,latin-ext,vietnamese'); No newline at end of file | |||
Member
Author
There was a problem hiding this comment.
Note for reviewers, this is out of scope, just to help out a Vela teammate in need 😇
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/needs-review
reviewed/needs-work
labels
phndiaye
approved these changes
May 5, 2026
OwenCoogan
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before fix (misaligned top corners):
After fix:
Good PR checklist