Skip to content
This repository was archived by the owner on Aug 3, 2022. It is now read-only.

update small button size and deprecate the xs one#145

Open
phndiaye wants to merge 2 commits into
masterfrom
pn/backlog-1705/update-btn-small-height
Open

update small button size and deprecate the xs one#145
phndiaye wants to merge 2 commits into
masterfrom
pn/backlog-1705/update-btn-small-height

Conversation

@phndiaye
Copy link
Copy Markdown
Member

@phndiaye phndiaye commented Jun 23, 2022

What does this PR do?

Update the height of the button's size small and deprecate the xs one.

Related to : https://github.com/upfluence/backlog/issues/1705

What are the observable changes?

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated documentation
  • Properly labeled

Additional Notes

@phndiaye phndiaye requested review from a team, JulienVannier66 and Miexil as code owners June 23, 2022 15:31
@phndiaye phndiaye requested review from sBenjamin270495 and removed request for a team June 23, 2022 15:31
@phndiaye phndiaye force-pushed the pn/backlog-1705/update-btn-small-height branch from e8b6b51 to eac5dd4 Compare June 24, 2022 08:23
@phndiaye phndiaye self-assigned this Jun 24, 2022
Comment thread less/base/_buttons.less Outdated

.upf-btn--small, .upf-btn--sm {
height: @input-size-sm;
height: 24px;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use spacing css-vars ?

Comment thread less/base/_buttons.less Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants