Skip to content

test: remove release please test, as it is uneeded#16

Merged
zapper-95 merged 1 commit into
mainfrom
remove-release-please
May 15, 2025
Merged

test: remove release please test, as it is uneeded#16
zapper-95 merged 1 commit into
mainfrom
remove-release-please

Conversation

@zapper-95

@zapper-95 zapper-95 commented May 15, 2025

Copy link
Copy Markdown
Collaborator
  • The purpose of this repo is for the UpRoll CLI to clone it. It is not designed to be standalone package with releases. We therefore do not require automatic releases made by release-please.

@zapper-95 zapper-95 marked this pull request as ready for review May 15, 2025 12:24
@zapper-95 zapper-95 merged commit b78d147 into main May 15, 2025
22 checks passed
@ExploitSori

ExploitSori commented May 16, 2025

Copy link
Copy Markdown

Hello, I have a question about the project, so I'm leaving a comment.
What I want to do is reducing the challenge time of L2 from 604800 seconds to 300 seconds. This is to reducing the test time for rolling up L2 -> L1.
So I changed optimism_package.chains.network_params.withdrawal_delay in network_params.yaml from 604800 to 300, optimism_package.chains.network_params.dispute_game_finality_delay 302400 to 150 .
The chain seems to be running fine, but when I call proofMaturityDelaySeconds()(uint256) on "optimismPortalProxyAddress", 604800 is printed. and "disputeGameFinalityDelaySeconds()(uint256)" 302400 returned.
I think there is a problem with the asset transfer from L2 -> L1. Is there any problem?
Thank you for making it.
Ps. Sorry I cannot speak english well. but I really want to solve this.

@Chomtana

Copy link
Copy Markdown

Hi @ExploitSori are you deploying a new chain with these parameters or are you adjusting these parameters for an existing chain (That you might have just deployed but you set them after you have deployed)

@ExploitSori

ExploitSori commented May 16, 2025

Copy link
Copy Markdown

I execute it with kurtosis run . --args-file ./network_params.yaml.

  op_contract_deployer_params:
    image: us-docker.pkg.dev/oplabs-tools-artifacts/images/op-deployer:v0.0.12
    l1_artifacts_locator: https://storage.googleapis.com/oplabs-contract-artifacts/artifacts-v1-fffcbb0ebf7f83311791534a41e65ef90df47797f9ca8f86941452f597f7128c.tar.gz
    l2_artifacts_locator: https://storage.googleapis.com/oplabs-contract-artifacts/artifacts-v1-fffcbb0ebf7f83311791534a41e65ef90df47797f9ca8f86941452f597f7128c.tar.gz

It seems that the contracts are deployed with the image and data above. It seems that the contract with the challenge period set to 7 days is deployed in the image.

To change the challenge time, it seems that I need to modify network_params.yaml, set the OptimismPortal2 constructor, deploy it, and then upgrade optimismPortalProxy. Could you please check if this is the right way to do it? Or can I set it separately in kurtosis run . --args-file ./network_params.yaml?

And do I need to redeploy all the contracts related to the challenge time? If you know of any information that needs to be changed, please let me know.

I would like to know how to deploy a contract with a modified challenge time. I don't want to spend a lot of time testing transferring assets from L2 -> L1.

Thanks. @Chomtana

@Chomtana

Copy link
Copy Markdown

I don't think kurtosis can update params of an existing chain at this stage. It's designed for setting initial params of a completely new deployment only.

You might have to redeploy everything not just related contract

@ExploitSori

Copy link
Copy Markdown

I know that the testnet also has a 7 day challenge period. Are all developers waiting 7 days to migrate from L2 to L1?
Are there other testnets or methods of deployment? Are there any testnets with shorter rollup challenge periods other than those using foundry or zk based rollups?
How are other developers working on it?

@Chomtana

Copy link
Copy Markdown

I think it should works with under 7 days.

You could ask about this on https://github.com/ethereum-optimism/developers/discussions there will be more dev looking into

@ExploitSori

Copy link
Copy Markdown

Thank you for your answer. I will talk about it in the place you suggested.

@ExploitSori

Copy link
Copy Markdown

If the @upnodedev team is aware of a solution, I would appreciate it if you could kindly let me know. Please feel free to contact me at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants