DX-2609: fix: close delete confirmation modal after successful deletion#53
Open
DX-2609: fix: close delete confirmation modal after successful deletion#53
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alitariksahin
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DX-2609: in the Data Browser, deleting a list item left the confirmation popup open, letting users keep clicking Delete and silently delete subsequent items.
Root cause:
DeleteKeyModaldid not close itself afteronDeleteConfirmresolved. The three callsites that use it in uncontrolled mode (display-list.tsxper-row trash,item-actions.tsxdropdown,key-actions.tsxdropdown) had no way to dismiss the dialog.Fix: call
setIsOpen?.(false)after a successfulonDeleteConfirmindelete-key-modal.tsx. Stays inside thetryso a failed mutation keeps the modal open for retry. The two controlled callsites (sidebar-context-menu.tsx,item-context-menu.tsx) already close manually — those calls become redundant but are harmless.