Skip to content

removed expect_silent commented tests and make dev version number #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bburns632 merged 2 commits into from
Jan 28, 2026
Merged

removed expect_silent commented tests and make dev version number #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf72237
delete commented out expect_silent tests
bburns632 Jan 28, 2026
9f25c6a
dev version number
bburns632 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: pkgnet
Type: Package
Title: Get Network Representation of an R Package
Version: 0.6.0
Version: 0.6.0.9999
Authors@R: c(
person("Brian", "Burns", email = "brian.burns.opensource@gmail.com", role = c("aut", "cre")),
person("James", "Lamb", email = "jaylamb20@gmail.com", role = c("aut")),
Expand Down
7 changes: 7 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# development
## NEW FEATURES

## CHANGES

## BUGFIXES

# pkgnet 0.6.0
## NEW FEATURES

Expand Down
5 changes: 0 additions & 5 deletions tests/testthat/test-DependencyReporter-class.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ test_that('DependencyReporter works end-to-end for typical use', {
})

## Node and Edge extraction work ##
#expect_silent({testObj$nodes})
#expect_silent({testObj$edges})

expect_true(data.table::is.data.table(testObj$nodes))
expect_true(object = is.element("node", names(testObj$nodes))
, info = "Node column created")
Expand All @@ -63,7 +60,6 @@ test_that('DependencyReporter works end-to-end for typical use', {
, info = "TARGET and SOURCE fields in edge table at minimum")

## pkg_graph works ##
#expect_silent({testObj$pkg_graph})
expect_true({"AbstractGraph" %in% class(testObj$pkg_graph)})
expect_true({"DirectedGraph" %in% class(testObj$pkg_graph)})
expect_true({igraph::is_igraph(testObj$pkg_graph$igraph)})
Expand Down Expand Up @@ -95,7 +91,6 @@ test_that('DependencyReporter works end-to-end for typical use', {
})

## graph_viz works ##
#expect_silent({testObj$graph_viz})
expect_true(object = is.element("visNetwork", attributes(testObj$graph_viz)))
expect_equivalent(
object = as.data.table(testObj$graph_viz$x$nodes)[, .(id)]
Expand Down
10 changes: 0 additions & 10 deletions tests/testthat/test-FunctionReporter-class.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,6 @@ test_that('FunctionReporter works end-to-end for typical use', {
, info = "$pkg_name did not return expected package name")

## Node and Edge extraction work ##
# expect_silent({
# testObj$nodes
# testObj$edges
# })

expect_true(data.table::is.data.table(testObj$nodes))
expect_true(object = is.element("node", names(testObj$nodes))
, info = "Node column created")
Expand All @@ -74,8 +69,6 @@ test_that('FunctionReporter works end-to-end for typical use', {


## pkg_graph works ##

#expect_silent({testObj$pkg_graph})
expect_true({"AbstractGraph" %in% class(testObj$pkg_graph)})
expect_true({"DirectedGraph" %in% class(testObj$pkg_graph)})
expect_true({igraph::is_igraph(testObj$pkg_graph$igraph)})
Expand Down Expand Up @@ -118,7 +111,6 @@ test_that('FunctionReporter works end-to-end for typical use', {
)

## graph_viz works ##
#expect_silent({testObj$graph_viz})
expect_true(object = is.element("visNetwork", attributes(testObj$graph_viz)))
expect_equivalent(
object = as.data.table(testObj$graph_viz$x$nodes)[, .(id)]
Expand All @@ -136,15 +128,13 @@ test_that('FunctionReporter works end-to-end for typical use', {

test_that('FunctionReporter can directly generate pkg_graph', {
testObj <- FunctionReporter$new()$set_package("baseballstats")
#expect_silent(testObj$pkg_graph)
expect_true("AbstractGraph" %in% class(testObj$pkg_graph))
expect_true(object = igraph::is_igraph(testObj$pkg_graph$igraph)
, info = "Package graph did not successfuly generate igraph object")
})

test_that('FunctionReporter can directly generate graph_viz', {
testObj <- FunctionReporter$new()$set_package("baseballstats")
#expect_silent({testObj$graph_viz})
expect_true(object = is.element("visNetwork", attributes(testObj$graph_viz)))
})

Expand Down
7 changes: 0 additions & 7 deletions tests/testthat/test-InheritanceReporter-class.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@ test_that('InheritanceReporter Methods Work', {
})

## Node and Edge extraction work ##
#expect_silent({
# testObj$nodes
# testObj$edges
#})

expect_true(data.table::is.data.table(testObj$nodes))
expect_true(object = is.element("node", names(testObj$nodes))
, info = "Node column created")
Expand All @@ -65,7 +60,6 @@ test_that('InheritanceReporter Methods Work', {
, info = "TARGET and SOURCE fields in edge table at minimum")

## pkg_graph works ##
#expect_silent({testObj$pkg_graph})
expect_true({"AbstractGraph" %in% class(testObj$pkg_graph)})
expect_true({"DirectedGraph" %in% class(testObj$pkg_graph)})
expect_true({igraph::is_igraph(testObj$pkg_graph$igraph)})
Expand Down Expand Up @@ -97,7 +91,6 @@ test_that('InheritanceReporter Methods Work', {
})

## graph_viz works ##
#expect_silent({testObj$graph_viz})
expect_true(object = is.element("visNetwork", attributes(testObj$graph_viz)))
expect_equivalent(
object = as.data.table(testObj$graph_viz$x$nodes)[, .(id)]
Expand Down
18 changes: 0 additions & 18 deletions tests/testthat/test-plotting.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,24 +16,6 @@ test_that('node coloring by discrete and continuous', {
, palette = c("red", "green")
)

#expect_silent({
#
# b$.__enclos_env__$private$set_plot_node_color_scheme(
# field = "filename"
# , palette = c(
# "#E41A1C"
# , "#377EB8"
# , "#4DAF4A"
# , "#984EA3"
# , "#FF7F00"
# , "#FFFF33"
# , "#A65628"
# , "#F781BF"
# , "#999999"
# )
# )
#})

viz <- b$graph_viz
expect_is(viz, "visNetwork")
expect_is(viz, "htmlwidget")
Expand Down