Feature: Hide nested flags if hidden tag applied to parent#43
Merged
Juneezee merged 2 commits intourfave:mainfrom Jul 18, 2025
Merged
Feature: Hide nested flags if hidden tag applied to parent#43Juneezee merged 2 commits intourfave:mainfrom
Juneezee merged 2 commits intourfave:mainfrom
Conversation
Contributor
Author
|
Actually, I think I've got it wrong, this change would remove the nested flags, not 'hide' them, let me see if I can do it properly. |
When specified as options to the `Parse*` functions they change the behaviour of flag generation such that any structs tagged as `deprecated` or `hidden` tags applied to structs will be inherited by all child values.
7458ef2 to
b44b7fb
Compare
Contributor
Author
|
@Juneezee - thanks for looking. I've cleaned up the commits and description and I think it's ready for review now. |
Contributor
Author
|
Hi folks, any appetite for this change? |
Juneezee
reviewed
Jul 16, 2025
Member
Juneezee
left a comment
There was a problem hiding this comment.
This looks like a nice feature to have
dearchap
approved these changes
Jul 17, 2025
Juneezee
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This change introduces two new options
InheritHiddenandInheritDeprecatedwhich can be used with theParse*functions to mark all nested flags as eitherhiddenordeprecatedif a parentstructhas been tagged as eitherhiddenordeprecated.For example given the following
structdefinitionand a parser that looks like
you would end up with something like
instead of
Flags: --details-name --details-age --verboseI had initially made this behaviour default behaviour, but refactored to options in order to not break backwards compatibility.
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
I don't really like having both
inheritHiddenandhiddenoptions, but I haven't been able to figure out how to combine them. If you have any suggestions please let me know.Testing
New test cases have been added to
parser_test.goto test the behaviourRelease Notes