Improve python typings for PyCharm #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is how its look: 
|
Contributor
|
Thanks for attaching the screenshot! It made it easy for me to confirm that the same issue can be reproduced on my machine as well. I suspect that PyCharm's built-in type checker is inferring the type incorrectly. The same issue does not occur in VS Code (Pyright). In general, it's hard to justify changing the code just to work around a type checker's incorrect inference. However, PyCharm is a widely used IDE and there isn't a great alternative at the moment, so I agree that your proposed approach in this PR is the right direction. I'll take a bit more time to look into similar cases and any other possible alternatives, and then merge it. Thanks again for your contribution! |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes warnings in some cases like
PyCharm can't infer
TypedDict | stralias.