Skip to content

refactor: migrate gymnasia from v1 to v3#17

Merged
urmzd merged 2 commits intomainfrom
refactor/support-v3
Apr 10, 2026
Merged

refactor: migrate gymnasia from v1 to v3#17
urmzd merged 2 commits intomainfrom
refactor/support-v3

Conversation

@urmzd
Copy link
Copy Markdown
Owner

@urmzd urmzd commented Apr 9, 2026

Summary

  • Upgrade gymnasia dependency from v1.0 to v3.0 across workspace, lgp-core, and lgp-cli crates
  • Adapt to v3 API: Env::Action changed from usize to i64, reset() signature simplified, Flatten trait replaces Into<Vec<f64>>, StepResult replaces ActionReward, constructors no longer take RenderMode
  • Add Clone bound to GymRsEnvExt trait (required by v3 env types)

Test plan

  • All 23 unit + integration + smoke tests pass
  • Clippy clean (no new warnings)
  • Pre-commit (rustfmt + clippy) and pre-push (cargo test) hooks pass

urmzd added 2 commits April 9, 2026 10:16
Adapt to gymnasia v3 API changes: Env::Action is now i64, reset()
takes (Option<u64>, ResetOptions), observations use Flatten trait
instead of Into<Vec<f64>>, StepResult replaces ActionReward with
f64 reward, and constructors no longer take RenderMode.
…put structure

Update the performance benchmark to work with the new experiment runner output
directory structure. Change glob pattern from assets/experiments to outputs/,
update path extraction logic to use Option chaining instead of repeated parent
traversals, and add config directory mapping for each benchmark type.

Also add defensive check that skips benchmark types with no data found and
provides diagnostic output to aid debugging.
@urmzd urmzd merged commit 9012e1a into main Apr 10, 2026
2 checks passed
@urmzd urmzd deleted the refactor/support-v3 branch April 10, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant