feat: add @urql/tanstack-react-router#3729
feat: add @urql/tanstack-react-router#3729schiller-manuel wants to merge 2 commits intourql-graphql:mainfrom
Conversation
🦋 Changeset detectedLatest commit: cae0d95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schiller-manuel
force-pushed
the
tanstack-integration
branch
from
892648c to
cae0d95
Compare
| }, | ||
| "main": "dist/urql-tanstack-react-router.js", | ||
| "module": "dist/urql-tanstack-react-router.es.js", | ||
| "types": "dist/urql-tanstack-react-router.d.ts", |
There was a problem hiding this comment.
You are missing the export mappings, examples in other packages
There was a problem hiding this comment.
i was looking at packages/react-urql/package.json which also does not have export mappings.
Why do we need export mappings here?
There was a problem hiding this comment.
React-urql is a special case due to some old frameworks, vite is a good bundler so we should incorporate export mappings to future proof the package. What we do with react-urql is still a bit of a pickle, especially with regards to react-native
|
Hi @JoviDeCroock @schiller-manuel -- just curious about the status of this. Happy to jump in and help get this across finish line |
|
Also wondering on this. Would love see urql+tanstack-react-router playing along. |
|
@schiller-manuel I can finish this if you would like to, the only missing thing is the export mapping |
|
Can we get a |
5 participants
Summary
integration of @tanstack/react-router