feat: support nested pagination arguments in relay pagination#3795
Open
jtomaszewski wants to merge 1 commit intourql-graphql:mainfrom
Open
feat: support nested pagination arguments in relay pagination#3795jtomaszewski wants to merge 1 commit intourql-graphql:mainfrom
jtomaszewski wants to merge 1 commit intourql-graphql:mainfrom
Conversation
🦋 Changeset detectedLatest commit: dec3cd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Add extractPaginationArgs function to handle nested pagination args - Update compareArgs to areNonPaginationArgsEqual for better arg filtering - Support common nested patterns: paging, pagination, page - Add comprehensive test for nested pagination functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
jtomaszewski
force-pushed
the
feat/relay-pagination-nested-args
branch
from
615df04 to
dec3cd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our GraphQL server library ( https://doug-martin.github.io/nestjs-query/docs/graphql/paging/#relation-connections ) uses slightly different format for pagination args: instead of
items(first: 2, after: "xyz"), we doitems(paging: { first: 2, after: "xyz" }).Currently
relayPaginationutility allows only for args to be set at the top-level.Could we extend it to fit more use cases? In this PR, I'm keeping the exitsing behaviour, but also make it work with pagination args placed under the
paging.,pagination.orpage.object.