-
Notifications
You must be signed in to change notification settings - Fork 1
Minor fixes: build/extension warnings, dead links, improved formatting #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| [codelinks.projects.eac-cpp] | ||
| remote_url_pattern = "https://github.com/useblocks/eac/blob/{commit}/{path}#L{line}" # URL pattern for remote source code | ||
| remote_url_pattern = "https://github.com/useblocks/x-as-code/blob/{commit}/{path}#L{line}" # URL pattern for remote source code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally, shall we consequently change eac-cpp to x-as-code-cpp in the whole repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnoox yes, that would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe in a follow up issue
patdhlk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment, can be done in a follow up or now. Approved
docs/src_trace.toml: fixed dead link generation to source code.docs/tutorials/sphinx-needs-setup.rst: updated formatting.docs/tutorials/sphinx-needs-setup.rst: removed dead ref (from user perspective) from code block: https://github.com/useblocks/x-as-code/pull/20/files#diff-3431e5b4d502b5f3181c98fa9d9a70e88b5de8d28c8c03ae44a2101019850fb0R600docs/ubproject.toml: ignore src-trace (produces a lint warning in vs-code).src/CMakeLists.txt: use exact time stamps for gtest