fix: duplicate toast when opening an already-opened collection#64
Open
chirag-bruno wants to merge 1 commit into
Open
fix: duplicate toast when opening an already-opened collection#64chirag-bruno wants to merge 1 commit into
chirag-bruno wants to merge 1 commit into
Conversation
The open collection flow broadcast toast/error messages to all webviews via messageSender, causing the same notification to appear in both the sidebar and every open tab editor. Switch to native VS Code notifications (showInformationMessage, showErrorMessage) which display a single notification regardless of how many webviews are active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When opening an already-opened collection, the "Collection is already opened" toast appeared twice — once in the sidebar and once in the tab editor. Similarly, error messages like "The collection is not valid" showed in both places.
Root Cause
The
openCollectionDialogandopenCollectionfunctions usedmessageSender(which broadcasts to ALL webviews) to sendmain:toast-successandmain:display-errorevents. Every webview with a<Toaster>rendered the notification independently.Solution
Replace
messageSender('main:toast-success', ...)andmessageSender('main:display-error', ...)with nativevscode.window.showInformationMessageandvscode.window.showErrorMessage. These display a single notification in VS Code's notification area.Test plan