Skip to content

Fixes linting issues with nested Sprintf()s #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreddedbacon merged 1 commit into from
Mar 10, 2026
Merged

Fixes linting issues with nested Sprintf()s #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var webCmd = &cobra.Command{
urlBuilder := strings.Builder{}
urlBuilder.WriteString(lagoonCLIConfig.Lagoons[lagoonCLIConfig.Current].UI)
if lagoonCLIConfig.Lagoons[lagoonCLIConfig.Current].UI != "" {
urlBuilder.WriteString(fmt.Sprintf("/projects/%s", cmdProjectName))
fmt.Fprintf(&urlBuilder,"/projects/%s", cmdProjectName)
} else {
handleError(fmt.Errorf("unable to determine url for ui, is one set?"))
}
Expand Down
10 changes: 5 additions & 5 deletions pkg/output/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,17 +89,17 @@ func RenderResult(result Result, opts Options) string {
return RenderJSON(result, opts)
} else {
if trimQuotes(result.Result) == "success" {
out.WriteString(fmt.Sprintf("Result: %s\n", aurora.Green(trimQuotes(result.Result))))
fmt.Fprintf(&out, "Result: %s\n", aurora.Green(trimQuotes(result.Result)))
if len(result.ResultData) != 0 {
for k, v := range result.ResultData {
out.WriteString(fmt.Sprintf("%s: %v\n", k, v))
fmt.Fprintf(&out, "%s: %v\n", k, v)
}
}
} else {
fmt.Printf("Result: %s\n", aurora.Yellow(trimQuotes(result.Result)))
fmt.Fprintf(&out, "Result: %s\n", aurora.Yellow(trimQuotes(result.Result)))
if len(result.ResultData) != 0 {
for k, v := range result.ResultData {
out.WriteString(fmt.Sprintf("%s: %v\n", k, v))
fmt.Fprintf(&out, "%s: %v\n", k, v)
}
}
}
Expand All @@ -111,7 +111,7 @@ func RenderResult(result Result, opts Options) string {
func RenderOutput(data Table, opts Options) string {
var out bytes.Buffer
if opts.Debug {
out.WriteString(fmt.Sprintf("%s\n", aurora.Yellow("Final result:")))
fmt.Fprintf(&out, "%s\n", aurora.Yellow("Final result:"))
}
if opts.JSON {
// really basic tabledata to json implementation
Expand Down
Loading