feat: add static and dynamic custom dropdowns support#18
Open
ahasseyp-paragon wants to merge 3 commits intomainfrom
Open
feat: add static and dynamic custom dropdowns support#18ahasseyp-paragon wants to merge 3 commits intomainfrom
ahasseyp-paragon wants to merge 3 commits intomainfrom
Conversation
ahasseyp-paragon
requested review from
juanpa-paragon and
richardbidin-paragon
|
|
||
| export function DynamicCustomDropdownField(props: Props) { | ||
| const [searchQuery, setSearchQuery] = useState<string>(''); | ||
| const { ref, inView } = useInView(); |
Collaborator
There was a problem hiding this comment.
think we can use the useOnInView which takes a callback. This would replace the useEffect below
| allowClear | ||
| > | ||
| {allOptions.map((option) => ( | ||
| <ComboboxField.Item key={option.value} value={option.label}> |
Collaborator
There was a problem hiding this comment.
why are we using the label as the value prop? This prop is intended to be unique fields. Using the value would remove the allOptions.find above as well
Comment on lines
+84
to
+96
| {hasNextPage && ( | ||
| <div | ||
| ref={ref} | ||
| className="flex items-center justify-center py-2 text-sm text-muted-foreground" | ||
| > | ||
| {isFetchingNextPage && ( | ||
| <div className="flex items-center gap-2"> | ||
| <LoaderCircle className="size-4 animate-spin" /> | ||
| Loading more... | ||
| </div> | ||
| )} | ||
| </div> | ||
| )} |
Comment on lines
+171
to
+173
| customDropdownLoader={ | ||
| (customDropdownOptions as CustomDropdownOptions).loadOptions | ||
| } |
Collaborator
There was a problem hiding this comment.
think this prop could named as onLoad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Closed
Brief Summary
add dynamic custom dropdown support with pagination