Skip to content

record/flake [20260422-192404]#3

Closed
rnagulapalle wants to merge 2 commits intomainfrom
record/flake-20260422-192404
Closed

record/flake [20260422-192404]#3
rnagulapalle wants to merge 2 commits intomainfrom
record/flake-20260422-192404

Conversation

@rnagulapalle
Copy link
Copy Markdown
Contributor

No description provided.

@rnagulapalle
Copy link
Copy Markdown
Contributor Author

I diagnosed this as a PR-introduced flaky test rather than a main-branch issue.

  • The GitHub Actions log for job 72573133206 shows com.phalanx.calc.MathOpsTest.multiplyWithJitter timing out after 2 seconds during mvn -B verify.
  • The PR diff shows this branch added multiplyWithJitter() with @Timeout(2) but also Thread.sleep((long) (Math.random() * 3000)), so the test can legitimately sleep longer than its own timeout.
  • git blame shows the failing lines were introduced in commit 0846b12 on this PR.
  • I also checked recent main history for this failure signature and did not find evidence of an existing default-branch failure.

I’ve prepared a minimal fix: make multiplyWithJitter() deterministic by removing the random sleep and the now-unused timeout/imports, while still asserting MathOps.multiply(2, 3) == 6.0.

I verified the exact failing command in sandbox:

mvn -B verify

and it now passes successfully, including the coverage gate.

Next step: I’m pushing that scoped test fix onto this PR branch now.

The PR added multiplyWithJitter with a 2 second timeout but also a random
sleep up to 3 seconds, making the test fail nondeterministically in CI.
Remove the timing jitter and unused imports so mvn -B verify passes
reliably while preserving the multiplication assertion.
@rnagulapalle rnagulapalle deleted the record/flake-20260422-192404 branch April 22, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant