Skip to content

feat ydb: dedicate operation_timeout and cancel_after from client_timeout #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gazizonoki wants to merge 1 commit into from
+19 −0
Closed

feat ydb: dedicate operation_timeout and cancel_after from client_timeout #1156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ydb/src/ydb/impl/operation_settings.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ USERVER_NAMESPACE_BEGIN

namespace ydb::impl {

constexpr double kOperationTimeoutMultiplier = 0.8;

std::chrono::milliseconds GetBoundTimeout(std::chrono::milliseconds timeout, engine::Deadline deadline);

NYdb::NQuery::TExecuteQuerySettings ToExecuteQuerySettings(const QuerySettings& query_settings);
Expand All @@ -33,6 +35,23 @@ void ApplyToRequestSettings(
}
}

template <typename T>
void ApplyToRequestSettings(
NYdb::TOperationRequestSettings<T>& result,
const OperationSettings& settings,
engine::Deadline deadline
) {
auto timeout = GetBoundTimeout(settings.client_timeout_ms, deadline);

result.ClientTimeout(timeout);
result.OperationTimeout(timeout * kOperationTimeoutMultiplier);
result.CancelAfter(timeout * kOperationTimeoutMultiplier);

if (!settings.trace_id.empty()) {
result.TraceId(impl::ToString(settings.trace_id));
}
}

template <typename T>
T PrepareRequestSettings(const OperationSettings& settings, engine::Deadline deadline) {
T result;
Expand Down
Loading