chaotic: IsConvertible helper function for string enums#1157
Open
rsaddatimov wants to merge 4 commits intouserver-framework:developfrom
Open
chaotic: IsConvertible helper function for string enums#1157rsaddatimov wants to merge 4 commits intouserver-framework:developfrom
rsaddatimov wants to merge 4 commits intouserver-framework:developfrom
Conversation
apolukhin
requested changes
Mar 26, 2026
| {% endif %} | ||
| {% endmacro %} | ||
|
|
||
| {% macro generate_isvalid_definition(type) %} |
Member
There was a problem hiding this comment.
For what cases this function is required? What is the motivation of this PR?
Author
There was a problem hiding this comment.
Similar to the protobuf's bool Enum_IsValid() and bool Enum_Parse() functions
Right now there is no way to perform enum validity check having string value, FromString throws
rsaddatimov
changed the title
rsaddatimov
force-pushed
the
feature/chaotic-enum-is-valid
branch
from
4675662 to
9742c87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.