Adding support for showing payload size, Plugin browser, custom fields editor and hot reloading plugins in web UI #77
Adding support for showing payload size, Plugin browser, custom fields editor and hot reloading plugins in web UI #77sd416 wants to merge 0 commit into
Conversation
|
@schrockwell, Can you please take a look at this? |
schrockwell
left a comment
There was a problem hiding this comment.
Thanks for taking the time to build out these improvements. There are some great ideas in here, and also some that are out of scope.
Additionally, this PR attempts to merge too many changes at once. It makes it difficult to review and discuss individual features. So I ask that you please split it out into a few separate branches:
- Fix #67 (see note below)
- Add
trmnlp list - Add custom field editor
- Add to
README
Acceptable
Add
trmnlp listcommand to list plugins from TRMNL server
Great addition! Please see the review comments for a few tweaks, and split out to a new PR.
Add custom fields editor with support for text inputs and dropdowns
Auto-populate custom field definitions from settings.yml
This feature is really nice. I am inclined to approve it, but please split into a separate PR.
Add Docker interactive mode documentation to README
This is a great tidbit, thank you.
Won't Accept
Add support for showing response size
This actually does not solve #67. The goal is to show the size of the data payload (JSON, XML, CSV, text, etc) from polling or webhook. On the positive side, the actual fix is much simpler.
Add plugin selector dropdown in web UI for browsing and loading plugins
Add hot-load API endpoint (/api/pull/:id) to switch plugins without restarting.
Sorry, these changes cannot be accepted as currently implemented. It goes against the design philosophy of trmnlp which is to serve up a single plugin from a directory. Overwriting the src/ directory is potentially destructive and makes very little sense for directories that are under version control.
|
|
||
| begin | ||
| api = APIClient.new(@context.config) | ||
| response = api.get_plugin_settings |
There was a problem hiding this comment.
- This should return only plugin_settings with
plugin_id == 37which is the ID for private plugins. - Please sort the response, preferably by
name.
|
#84 created for trmnlp list support |
|
#85 is created for docker interactive readme update |
|
#86 is created for adding support for field editor on the webui |
Fix for #67
compressed.mp4