feat: show default session notes persistently#15
Merged
Conversation
Added configuration option to control whether default session notes are always displayed in the background when no named session or retrace mode is active. Default: true (enabled)
Added functionality to display default session notes in the background when no named session or retrace mode is active. - Setup default session display on VimEnter - Auto-update display when entering buffers - Only show when no active session or retrace mode - Helper functions to setup and clear display autocmds
Modified session start/end commands to properly manage default session display: - Clear default session notes when starting a named session - Restore default session display when ending a session - Only applies when show_default_notes config is enabled
Modified retrace start/stop to properly manage default session display: - Clear default session notes when entering retrace mode - Restore default session display when exiting retrace mode - Only applies when show_default_notes config is enabled
Added 19 new test cases covering: Config tests (test/tabi/config_spec.lua): - Verify show_default_notes defaults to true - Test configuration override Integration tests (test/tabi/integration/default_session_display_spec.lua): - Startup behavior with/without default session - Session start/end integration - Retrace mode integration - Autocmd lifecycle management - Complex scenarios and edge cases Also fixed _setup_default_session_display() to check config before executing, preventing unnecessary work when feature is disabled. All 386 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
show_default_notesconfiguration option to display default session notes persistently in the background when no named session or retrace mode is active.Key features:
show_default_notesoption (default:true)Changes
Configuration
lua/tabi/config.lua: Addedshow_default_notesoption (default:true)Core Implementation
lua/tabi/init.lua:_setup_default_session_display()to setup background display_clear_default_session_display()to cleanup autocmdsIntegration
plugin/tabi.lua:lua/tabi/retrace.lua:Tests
test/tabi/config_spec.lua: Config tests (3 cases)test/tabi/integration/default_session_display_spec.lua: Comprehensive integration tests (16 cases)Behavior
When
show_default_notes: true(default):When
show_default_notes: false:Test plan