Bump dependency.log4j2.version from 2.22.0 to 2.22.1 #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps `dependency.log4j2.version` from 2.22.0 to 2.22.1. Updates `org.apache.logging.log4j:log4j-api` from 2.22.0 to 2.22.1 Updates `org.apache.logging.log4j:log4j-core` from 2.22.0 to 2.22.1 --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.logging.log4j:log4j-core dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
aj-stein-nist
previously approved these changes
Jan 31, 2024
Contributor
aj-stein-nist
left a comment
aj-stein-nist
left a comment
There was a problem hiding this comment.
Actually, I am going to reverse my decision on this because I have been bitten before and will want @david-waltermire's take on this. Per the changelog:
While maintaining compatibility with Java 8, the artifacts in this release where generated using JDK 17, unlike version 2.22.0 that used JDK 11.
I have been bitten by the differential JDK build issue where it all compiles but the JDK version mismatch at runtime causes issues, so I will want to review and test this since the GHA configuration says it uses Java 11 Temurin, I suspect this could be an issue, even if tests pass.
aj-stein-nist
dismissed
their stale review
Documentation on runtime review missed during first cursory review; further analysis needed.
Contributor
Author
|
Superseded by #241. |
dependabot
bot
deleted the
dependabot/maven/develop/dependency.log4j2.version-2.22.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
dependency.log4j2.versionfrom 2.22.0 to 2.22.1.Updates
org.apache.logging.log4j:log4j-apifrom 2.22.0 to 2.22.1Updates
org.apache.logging.log4j:log4j-corefrom 2.22.0 to 2.22.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)