Skip to content

Add support for FreeBSD.#38

Closed
grimreaper wants to merge 1 commit intousrbinnc:masterfrom
grimreaper:master
Closed

Add support for FreeBSD.#38
grimreaper wants to merge 1 commit intousrbinnc:masterfrom
grimreaper:master

Conversation

@grimreaper
Copy link
Copy Markdown

This is a mildly debugged first attempt: there are likely bugs. Be aware.

This is a mildly debugged first attempt: there are likely bugs.  Be aware.
@grimreaper
Copy link
Copy Markdown
Author

ugh - I think I missed some refactoring in the Linux version. This pull request will likely need to be updated

@pah
Copy link
Copy Markdown
Contributor

pah commented Apr 28, 2014

Indeed, there are no trk?.h headers anymore, so the PR won't work as is. The refactoring to individual track object files should fix the compiler issues on FreeBSD as well (include ordering, etc).

Secondly, the README.md needs to be updated to use -f Makefile.linux for the Linux build or just skip the renaming and assume Linux by default.

@grimreaper
Copy link
Copy Markdown
Author

Yeah, I noticed that after I filed the pull request :\ I'll work on fixing this and resubmit

@grimreaper grimreaper closed this Apr 28, 2014
@pah
Copy link
Copy Markdown
Contributor

pah commented Apr 28, 2014

Have you seen the FreeBSD porting effort by @f00stx at https://github.com/f00stx/netcat-cpi-kernel-module-bsd/commits/bsd?
Maybe it's a good idea to merge the different approaches and rebase them on the current Linux HEAD.

@grimreaper
Copy link
Copy Markdown
Author

@pah I think @f00stx's work is based on some of my original work. I'll have a new version shortly that addresses the main issues.

@f00stx
Copy link
Copy Markdown

f00stx commented Apr 29, 2014

@grimreaper Original code came from here, if that's you please let me know and I'll update the README with your github handle!

http://www.opendevs.org/mytuq/request-for-help-netcat-kernel-module-for-freebsd.html

@grimreaper
Copy link
Copy Markdown
Author

@f00stx yeah - I'm Eitan :) I didn't see your answer before. Did it make it to the mailing list? Feel free to email me directly so we don't bother @pah and friends anymore.

@pah
Copy link
Copy Markdown
Contributor

pah commented Apr 29, 2014

@grimreaper, to be clear, I'm merely an interested lurker as well, not part of netcat like @blucia0a and @dbalatero. I just did the refactoring to the individual track files, which is why I commented on your pull-request. :-)

@dbalatero
Copy link
Copy Markdown
Member

You can certainly reopen this pull request and push updated commits to it as you work on it?

@grimreaper
Copy link
Copy Markdown
Author

@pah heh okay. I appreciate the comments.
@dbalatero I ended up opening #42 - I'm not sure if there was a better way to do that? I pushed to the same branch so I wonder why github doesn't see them as the same.

@dbalatero
Copy link
Copy Markdown
Member

@grimreaper Probably because the PR was closed already, so it didn't bother
to update (and assumed you were re-creating a new pull request). If you
leave the PR open you can keep pushing.

On Tue, Apr 29, 2014 at 3:32 PM, grimreaper notifications@github.comwrote:

@pah https://github.com/pah heh okay. I appreciate the comments.
@dbalatero https://github.com/dbalatero I ended up opening #42https://github.com/usrbinnc/netcat-cpi-kernel-module/pull/42\- I'm not sure if there was a better way to do that? I pushed to the same
branch so I wonder why github doesn't see them as the same.


Reply to this email directly or view it on GitHubhttps://github.com//pull/38#issuecomment-41740563
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants