fix: make MtmdBitmap and MtmdContex Send + Sync#920
fix: make MtmdBitmap and MtmdContex Send + Sync#920MarcusDunn merged 1 commit intoutilityai:mainfrom
Conversation
|
I'll need safety comments for these. |
|
@MarcusDunn it follows exactly what ha been done here: https://github.com/utilityai/llama-cpp-rs/blob/main/llama-cpp-2/src/model.rs#L177 i've checked into the actual c++ implementation and it is thread-safe afaik. |
add a comment to this effect and we're good to go! My lack of comments on my own |
|
@MarcusDunn ping. btw in order to get this really working (mtmd) one of these PRs should be merged: do you want me to pick up one of those and address your feedbacks? or there is a fundamental reason you dont want to merge them? |
|
One is a draft. The other is pending PR comments. |
|
Feel free to get either across the finish line. I always appreciate contributions! |
|
@MarcusDunn if no objections i can address the comments. would be great having that finally fixed. |
|
Agreed! One you address the outstanding comments I may give another review to finish it off. |
No description provided.