Skip to content

fix: make MtmdBitmap and MtmdContex Send + Sync#920

Merged
MarcusDunn merged 1 commit intoutilityai:mainfrom
querymt:mtmd_sync
Feb 17, 2026
Merged

fix: make MtmdBitmap and MtmdContex Send + Sync#920
MarcusDunn merged 1 commit intoutilityai:mainfrom
querymt:mtmd_sync

Conversation

@vigsterkr
Copy link
Contributor

No description provided.

@MarcusDunn
Copy link
Contributor

I'll need safety comments for these.

@vigsterkr
Copy link
Contributor Author

@MarcusDunn it follows exactly what ha been done here: https://github.com/utilityai/llama-cpp-rs/blob/main/llama-cpp-2/src/model.rs#L177

i've checked into the actual c++ implementation and it is thread-safe afaik.

@MarcusDunn
Copy link
Contributor

MarcusDunn commented Feb 12, 2026

i've checked into the actual c++ implementation and it is thread-safe afaik.

add a comment to this effect and we're good to go!

My lack of comments on my own unsafe impls doesn't mean it's a good idea! :)

@vigsterkr
Copy link
Contributor Author

@MarcusDunn ping. btw in order to get this really working (mtmd) one of these PRs should be merged:
#810
#806

do you want me to pick up one of those and address your feedbacks? or there is a fundamental reason you dont want to merge them?

@MarcusDunn
Copy link
Contributor

One is a draft. The other is pending PR comments.

@MarcusDunn
Copy link
Contributor

Feel free to get either across the finish line. I always appreciate contributions!

@vigsterkr
Copy link
Contributor Author

@MarcusDunn if no objections i can address the comments. would be great having that finally fixed.

@MarcusDunn
Copy link
Contributor

Agreed! One you address the outstanding comments I may give another review to finish it off.

@MarcusDunn MarcusDunn merged commit c1f6114 into utilityai:main Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants