Use "Remove" button for Custom Games

[zeedif]

Updated the "Uninstall" button to say "Remove" when viewing a Custom Game, since we don't actually delete the game files from the disk, only the library entry.

Implemented using extractGameSourceFromContainerId as suggested.

---

Summary by cubic

Updated the Library screen to show “Remove” instead of “Uninstall” for Custom Games, since we only remove the library entry and don’t delete files. The label switches based on source using ContainerUtils.extractGameSourceFromContainerId.

^{Written for commit 447277b. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Improved button terminology in library management. The delete action now displays "Remove" for custom games and "Uninstall" for other apps, providing more accurate and context-specific labels to guide users through deletion actions.

[coderabbitai]

📝 Walkthrough

Walkthrough

The uninstall/delete button text in LibraryAppScreen is now conditionally set based on the container type. For CUSTOM_GAME containers, the button displays "Remove"; otherwise, it displays "Uninstall". The button's behavior remains unchanged.

Changes

Cohort / File(s)	Summary
Dynamic Button Text app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt	Button label now computed dynamically: "Remove" for CUSTOM_GAME containers, "Uninstall" for others. Conditional logic replaces static text constant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A button's name doth shift and change,
"Remove" or "Uninstall," what a range!
Custom games get their gentle call,
While others bid farewell to all.
Smart words for every download tall! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the main change: updating the button label to show 'Remove' instead of 'Uninstall' for custom games, which aligns with the core functionality modification.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt (1)

505-509: Consider passing the button label as a parameter to keep this composable presentation-only.

AppScreenContent is a shared, source-agnostic composable, but it now depends on ContainerUtils to determine button text. A cleaner approach would be to let each caller supply the appropriate label — or add a gameSource field to GameDisplayInfo — so this composable stays decoupled from container ID encoding.

That said, extractGameSourceFromContainerId is just a simple string prefix check (cheap operation), so the current approach is acceptable for a focused PR. If you'd prefer to refactor later, passing the label as a parameter would improve separation of concerns.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file

[phobos665]

Nice one!