Skip to content

Fix wrong key used in the opengl Win component label#519

Closed
Unnvaldr wants to merge 1 commit intoutkarshdalal:masterfrom
Unnvaldr:patch-1
Closed

Fix wrong key used in the opengl Win component label#519
Unnvaldr wants to merge 1 commit intoutkarshdalal:masterfrom
Unnvaldr:patch-1

Conversation

@Unnvaldr
Copy link

@Unnvaldr Unnvaldr commented Feb 11, 2026

Rationale

Duplicated label, which can be confusing at start.

What Changed

Just the label used for opengl Win Component, now reflecting its original meaning.

Impact

None.


Summary by cubic

Corrected the label mapping for the OpenGL Win component so it displays “OpenGL” instead of duplicating “WM Decoder.” This fixes the UI confusion in ContainerConfigDialog.

Written for commit f6f55f6. Summary will update on new commits.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the title display text for the OpenGL component.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

A string resource mapping in the ContainerConfigDialog was corrected, changing the "opengl" component's title resource from R.string.wmdecoder to R.string.opengl. This ensures the correct localized string is displayed for the component label.

Changes

Cohort / File(s) Summary
Dialog Component Resource Fix
app/src/main/java/app/gamenative/ui/component/dialog/ContainerConfigDialog.kt
Corrected the Win Components title resource mapping for the "opengl" component to reference the appropriate string resource instead of an unrelated decoder resource.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny fix, yet oh so true,
The opengl string finds its proper view,
No decoder strings in this dialog's sight,
Just one small change to make it right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing an incorrect string resource mapping for the opengl component's label from wmdecoder to opengl.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@Unnvaldr
Copy link
Author

Duplicate of #516

@Unnvaldr Unnvaldr closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant