feat: add Skip Steam Login button to login screen, if user just wants GOG, Epic, Custom Games#531
Conversation
… GOG, Epic, Custom Games
📝 WalkthroughWalkthroughAdds a conditional "Skip Steam login" TextButton to the UserLoginScreen that appears when a login attempt is not in progress and the login result is not success; it calls Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@app/src/main/java/app/gamenative/ui/screen/login/UserLoginScreen.kt`:
- Around line 404-430: The new "Skip Steam login" button duplicates the existing
"Continue Offline" action when isSteamConnected is false; update the UI to avoid
showing both. Either hide this bottom Column (the block rendering the TextButton
that calls onContinueOffline) when !isSteamConnected, or remove the "Continue
Offline" action from ModernUsernamePassword so only the bottom TextButton
remains; locate the condition around userLoginState.isLoggingIn /
userLoginState.loginResult and the TextButton using onContinueOffline and adjust
the visibility logic accordingly (check isSteamConnected before rendering the
bottom Column or remove the duplicate callback from ModernUsernamePassword).
Now that GN has Epic and GOG support, some users may want to use this app exclusively for those stores, or for custom games, and not necessarily want to log into Steam.
This just adds a non intrusive "Skip Steam Login" button at the bottom of the
UserLoginScreenso you can get into the app .Once in there the "go online" button brings you back to login page, so if user wants to use Steam later on they are not stranded.
There is potentially more work to be done to make steam epic and got all act the same way, but for now this is a small scope change that I think solves a real pain point.
Summary by cubic
Adds a "Skip Steam login" button so users can enter the app for GOG, Epic, or custom games without Steam. Users can return to Steam login later via the "Go online" flow.
New Features
Bug Fixes
Written for commit 2b03608. Summary will update on new commits.
Summary by CodeRabbit