Skip to content

Jb/scrollbars#537

Merged
utkarshdalal merged 2 commits intoutkarshdalal:masterfrom
jeremybernstein:jb/scrollbars
Feb 17, 2026
Merged

Jb/scrollbars#537
utkarshdalal merged 2 commits intoutkarshdalal:masterfrom
jeremybernstein:jb/scrollbars

Conversation

@jeremybernstein
Copy link
Contributor

@jeremybernstein jeremybernstein commented Feb 16, 2026


Summary by cubic

Adds vertical scrolling to the Library filter bottom sheet so all options are accessible on small screens and in landscape. Also fixes a macOS build error caused by an invalid UTF-8 sequence in a Korean string.

  • New Features

  • Bug Fixes

    • Escape quotes in values-ko/strings.xml to resolve invalid UTF-8 and restore macOS builds.

Written for commit 2c90519. Summary will update on new commits.

Summary by CodeRabbit

  • Bug Fixes
    • Enabled vertical scrolling in the library view for improved content navigation
    • Corrected Korean localization string formatting

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Added vertical scrolling capability to the LibraryBottomSheet component and included preview configurations for small-screen and landscape device modes. Fixed Korean string resource quote escaping.

Changes

Cohort / File(s) Summary
LibraryBottomSheet Scrolling & Previews
app/src/main/java/app/gamenative/ui/screen/library/components/LibraryBottomSheet.kt
Added vertical scrolling via verticalScroll(rememberScrollState()) modifier and two additional Preview annotations for small-screen and landscape configurations.
Korean String Resource Fix
app/src/main/res/values-ko/strings.xml
Escaped single quotes in main_pending_operation_none string value using backslash notation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

📜 A rabbit scrolls through bottom sheets with care,
Adding previews for screens both small and square,
Korean quotes now properly escaped,
Simple fixes, perfectly shaped! 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Jb/scrollbars' is a branch name format and does not clearly summarize the pull request's main changes to a reviewer. Use a descriptive title like 'Add vertical scrolling to library bottom sheet and fix UTF-8 encoding error' to clearly communicate the changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@utkarshdalal utkarshdalal merged commit d8580e9 into utkarshdalal:master Feb 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants