Feature/surface format setting

[xXJSONDeruloXx]

https://discord.com/channels/1378308569287622737/1472071060785725635

Hey guys I was recently testing out Doom Eternal on my snapdragon 8 elite gen 5 device and couldn't get it to load on Gamenative. I decided to test it on Gamehub lite and found that changing the surface option from RGBA8 to BGRA8 was the difference between the game running and the game not running.

Could we add the option to change Surface format within the 'edit container' graphics tab?

---

Summary by cubic

Adds a Surface Format option (RGBA8/BGRA8) in the Graphics tab to improve game compatibility. This enables titles like Doom Eternal on Snapdragon 8 Elite devices to launch by switching to BGRA8.

• New Features

  • Added Surface Format dropdown in Edit Container → Graphics.
  • Options: RGBA8 (default) and BGRA8.
  • Saves selection in graphicsDriverConfig as surfaceFormat.
  • XServer exports WRAPPER_SURFACE_FORMAT env var when set.
  • UI strings and array resources added.

• Migration

  • No required changes. For affected games, set Surface Format to BGRA8 in Graphics settings.

^{Written for commit 5066002. Summary will update on new commits.}

Summary by CodeRabbit

• New Features
  • Added Surface Format configuration option to graphics settings
  • Users can now select between RGBA8 and BGRA8 surface format options
  • Selected surface format preference is persisted and applied to the graphics driver

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

The pull request introduces surface format selection to the container configuration system. A new dropdown UI element in the graphics settings allows users to choose between RGBA8 and BGRA8 surface formats, with the selection tracked in state, persisted to configuration, and passed to the graphics driver via environment variables.

Changes

Cohort / File(s)	Summary
State Management ContainerConfigState.kt, ContainerConfigDialog.kt	Added surfaceFormatIndex (MutableIntState) and surfaceFormats (List) fields to the public state container, initialized from resources and persisted configuration with RGBA8 as default.
UI Components GraphicsTab.kt	Introduced new SettingsListDropdown for surface format selection in the Bionic graphics variant, binding the selection to state and persisting the chosen format to graphics driver configuration.
Environment Setup XServerScreen.kt	Integrated surface format handling into graphics driver environment variable setup, setting WRAPPER_SURFACE_FORMAT when a non-empty surface format is configured.
Resources arrays.xml, strings.xml	Added surface_format_entries string array with RGBA8 and BGRA8 options, and surface_format string resource for the UI label.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Once more attempted vortek with changes to renderercomponent, etc #108: Modifies XServerScreen.kt's environment variable setup, adding/altering env vars similar to the surfaceFormat implementation.
• Fix env vars #230: Updates ContainerConfigDialog.kt and container environment variable persistence, overlapping with the configuration handling in this change.
• fix(): Migrate all UI Strings to String Templates to enable Localisation Work #249: Modifies ContainerConfigDialog and adds resource strings, building on similar localization and dialog infrastructure.

Poem

🐰 A dropdown hops into the scene,
Where RGBA and BGRA gleam,
The format flows through state so clean,
To graphics cards' envVar dream! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Feature/surface format setting' clearly and concisely describes the main change: adding a configurable surface format option to the UI.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into master

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 6 files