Skip to content

Potential fix for code scanning alert no. 58: CORS misconfiguration for credentials transfer #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utsavjosh1 merged 1 commit into from
Apr 29, 2026
Merged

Potential fix for code scanning alert no. 58: CORS misconfiguration for credentials transfer #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions apps/api/src/middleware/error-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,21 @@ export function errorHandler(

// Ensure CORS headers are present even in error responses, but ONLY for trusted origins
const origin = _req.headers.origin;
if (origin) {
if (typeof origin === "string" && origin.length > 0) {
const allowedOrigins = WEB_URL
? WEB_URL.split(",")
.map((o) => o.trim().replace(/\/$/, ""))
.filter(Boolean)
: [];

const normalizedOrigin = origin.replace(/\/$/, "");
const normalizedOrigin = origin.trim().replace(/\/$/, "");
const matchedOrigin =
normalizedOrigin !== "null"
? allowedOrigins.find((o) => o === normalizedOrigin)
: undefined;

if (allowedOrigins.includes(normalizedOrigin)) {
res.setHeader("Access-Control-Allow-Origin", origin as string);
if (matchedOrigin) {
res.setHeader("Access-Control-Allow-Origin", matchedOrigin);
res.setHeader("Access-Control-Allow-Credentials", "true");
}
}
Expand Down
Loading