check peer connection when update lnd snapshot#102
Merged
EthanYuan merged 4 commits intoutxostack:developfrom Mar 24, 2025
Merged
Conversation
EthanYuan
force-pushed
the
check-peer-connection-when-update-lnd-snapshot
branch
from
e3fe5c2 to
ec98fd1
Compare
EthanYuan
force-pushed
the
check-peer-connection-when-update-lnd-snapshot
branch
from
ec98fd1 to
1e4bc7e
Compare
ShookLyngs
approved these changes
Mar 23, 2025
Flouse
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the logic for updating the LND channels snapshot by adding a check to ensure that peers are currently connected. The snapshot will now only be updated if:
This avoids unnecessary snapshot updates when the node is not connected to the network.
As a next step, if the LND snapshot includes a
local_pubkeyfield, we can cross-check it with the currently connected peers to further strengthen the validation logic.