Skip to content

install: don't reject existing non-regular targets as "invalid target" #13552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gooh456 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

install: don't reject existing non-regular targets as "invalid target" #13552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/uu/install/src/install.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,12 @@ fn standard(mut paths: Vec<OsString>, b: &Behavior) -> UResult<()> {
return Err(InstallError::SameFile(source.clone(), target.clone()).into());
}

if target.is_file() || is_new_file_path(&target) {
// An existing target that isn't a directory (regular file, device
// node, FIFO, socket, ...) should still go through the normal
// copy/overwrite path so the real removal failure is reported,
// instead of falling through to InvalidTarget's hardcoded
// "No such file or directory" (issue #9934).
if target.is_file() || is_new_file_path(&target) || (target.exists() && !target.is_dir()) {
#[cfg(unix)]
if let (Some(ref parent_fd), Some(ref filename)) = (target_parent_fd, target_filename) {
if b.compare && !need_copy(source, &target, b) {
Expand Down
Loading