od: report actual file open errors - #13609
Open
wtcpython wants to merge 3 commits into
Open
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
oech3
reviewed
Jul 28, 2026
| io::ErrorKind::PermissionDenied => "Permission denied", | ||
| _ => "I/O error", | ||
| io::ErrorKind::NotFound => "No such file or directory".to_owned(), | ||
| io::ErrorKind::PermissionDenied => "Permission denied".to_owned(), |
Contributor
There was a problem hiding this comment.
Please extract those error from e too.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12980.
odreduced file-open failures to three hard-coded messages, so errors such as opening a Unix socket were reported asI/O errorinstead of the platform's actual diagnostic.Format file-open failures with
uucore::error::strip_errno, preserving GNU-compatible errors without including raw OS error numbers. Add a Unix regression test that creates a socket and verifies the propagated diagnostic.