Skip to content

uniq: remove write_line_terminator macro - #13632

Open
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:uniq_remove_macro
Open

uniq: remove write_line_terminator macro#13632
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:uniq_remove_macro

Conversation

@cakebaker

Copy link
Copy Markdown
Contributor

This PR is a follow-up to #13249 and addresses #13249 (comment) . That change leaves a single usage of the write_line_terminator macro and so I removed it.

@xtqqczze

Copy link
Copy Markdown
Contributor

Could you use thiserror crate and introduce enum UniqError?

@cakebaker

Copy link
Copy Markdown
Contributor Author

Hm, I think it's outside the scope of this PR.

@sylvestre

Copy link
Copy Markdown
Contributor

sorry, missed it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants