Skip to content

tar: Implement double verbose option#277

Open
dezgeg wants to merge 1 commit into
uutils:mainfrom
dezgeg:vv
Open

tar: Implement double verbose option#277
dezgeg wants to merge 1 commit into
uutils:mainfrom
dezgeg:vv

Conversation

@dezgeg
Copy link
Copy Markdown

@dezgeg dezgeg commented May 5, 2026

Implement double verbose (-vv) option to create and extract operations. This output is in same format as already implemented in list.rs so move that to common and reuse it.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 91.57895% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.44%. Comparing base (b469a73) to head (bc6d26c).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
src/uu/tar/src/display.rs 87.17% 5 Missing ⚠️
src/uu/tar/src/operations/create.rs 72.72% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #277       +/-   ##
===========================================
+ Coverage   76.30%   96.44%   +20.14%     
===========================================
  Files           9       10        +1     
  Lines         941      985       +44     
  Branches       24       26        +2     
===========================================
+ Hits          718      950      +232     
+ Misses        223       34      -189     
- Partials        0        1        +1     
Flag Coverage Δ
macos_latest 96.44% <91.57%> (+20.14%) ⬆️
ubuntu_latest 96.44% <91.57%> (+20.14%) ⬆️
windows_latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@kaladron kaladron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for this and sorry for the delay in reviewing them! There are two changes within that I'd appreciate you checking. Plus it would be nice to have tests to catch these:

  • A symlink case for create -vv.
  • A directory case that asserts the trailing slash in create -vv output.

Thank you!

Comment thread src/uu/tar/src/operations/create.rs Outdated
Comment thread src/uu/tar/src/display.rs Outdated
@dezgeg dezgeg force-pushed the vv branch 4 times, most recently from 2b27aad to df182a1 Compare May 17, 2026 16:42
Implement double verbose (-vv) option to create and extract operations.
This output is in same format as already implemented in list.rs so move
that to common and reuse it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants