Skip to content

Unifier.IsCompatibleWithPointer: add missing brackets around (DomainSelector | Domain.Pointer)#1298

Open
ptomin wants to merge 1 commit into
uxmal:masterfrom
ptomin:fix-is-compatible-with-pointer
Open

Unifier.IsCompatibleWithPointer: add missing brackets around (DomainSelector | Domain.Pointer)#1298
ptomin wants to merge 1 commit into
uxmal:masterfrom
ptomin:fix-is-compatible-with-pointer

Conversation

@ptomin

@ptomin ptomin commented Nov 30, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@uxmal

uxmal commented Dec 11, 2023

Copy link
Copy Markdown
Owner

@ptomin: I've added the fixes suggested in this PR to the master branch in another commit. Can you rebase this PR on top of master and see if there are any problems? It's possible this PR may have become redundant.

@ptomin ptomin force-pushed the fix-is-compatible-with-pointer branch from 13e03c7 to ba91740 Compare December 12, 2023 17:26
@ptomin

ptomin commented Dec 12, 2023

Copy link
Copy Markdown
Collaborator Author

@ptomin: I've added the fixes suggested in this PR to the master branch in another commit. Can you rebase this PR on top of master and see if there are any problems? It's possible this PR may have become redundant.

Done.
But haven't seen your "another commit" at the master branch.

@uxmal

uxmal commented Dec 18, 2023

Copy link
Copy Markdown
Owner

@ptomin, please rebase again, I'm having difficulties with typing-fixes branch. It will have to wait.

@ptomin ptomin force-pushed the fix-is-compatible-with-pointer branch from b8128c8 to 94f028e Compare December 21, 2023 15:42
@ptomin

ptomin commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator Author

Rebased. But there are still regressions.

@uxmal uxmal force-pushed the master branch 3 times, most recently from abe1eef to 2b92b95 Compare May 7, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants