feat: Improve error messaging for discover routes#53
Closed
mshabarov wants to merge 3 commits into
Closed
Conversation
Contributor
Author
/format |
github-project-automation
Bot
moved this to 🔎Iteration reviews
in Vaadin Flow | Hilla | Kits ongoing work
mshabarov
moved this from 🔎Iteration reviews
to ⚒️ In progress
in Vaadin Flow | Hilla | Kits ongoing work
mshabarov
moved this from ⚒️ In progress
to 🔎Iteration reviews
in Vaadin Flow | Hilla | Kits ongoing work
mcollovati
reviewed
May 21, 2026
| .map(pkg -> routesCache.computeIfAbsent(pkg, | ||
| p -> new Routes().autoDiscoverViews(p))) | ||
| .reduce(new Routes(), Routes::merge); | ||
| } catch (ServiceConfigurationError e) { |
Contributor
There was a problem hiding this comment.
I think this is not the right place to handle the exception. ServiceConfigurationError is never thrown during autoDiscoverViews() execution.
According to this comment, most likely the error comes from Flow initialization that happens later on.
We need to try to reproduce the issue and verify if we need to move this patch to another point in the codebase.
Contributor
|
I couldn't find a way to reproduce any |
github-project-automation
Bot
moved this from 🔎Iteration reviews
to Done
in Vaadin Flow | Hilla | Kits ongoing work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
ServiceConfigurationErrormore informative for browserless testing. Says that it's needed to overridediscoverRoutesto get the tests to run.