Skip to content

feat: configure spotless maven plugin for code formatting#513

Merged
mcollovati merged 2 commits into
mainfrom
claude/slack-session-ciPZu
May 27, 2026
Merged

feat: configure spotless maven plugin for code formatting#513
mcollovati merged 2 commits into
mainfrom
claude/slack-session-ciPZu

Conversation

@Artur-

@Artur- Artur- commented May 25, 2026

Copy link
Copy Markdown
Member

Configure the spotless plugin with settings matching Vaadin Flow:

  • Add VaadinJavaConventions.xml for Eclipse formatter settings
  • Add cdi.importorder for import ordering
  • Add apache2-license-header.txt for license headers
  • Configure Java formatting with forbidden wildcard imports
  • Configure POM sorting

This resolves #509.

https://claude.ai/code/session_01S7HsGqoR2cKkfdpxzYGqnW

Configure the spotless plugin with settings matching Vaadin Flow:
- Add VaadinJavaConventions.xml for Eclipse formatter settings
- Add cdi.importorder for import ordering
- Add apache2-license-header.txt for license headers
- Configure Java formatting with forbidden wildcard imports
- Configure POM sorting

This resolves #509.

https://claude.ai/code/session_01S7HsGqoR2cKkfdpxzYGqnW
@cla-assistant

cla-assistant Bot commented May 25, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown

Test Results

122 tests  ±0   122 ✅ ±0   2m 11s ⏱️ +7s
 33 suites ±0     0 💤 ±0 
 33 files   ±0     0 ❌ ±0 

Results for commit 5291dfd. ± Comparison against base commit c145fa6.

♻️ This comment has been updated with latest results.

@mcollovati mcollovati left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have format check in the validation workflow, but can be done in another PR.

@mcollovati

Copy link
Copy Markdown
Contributor

@Artur- is you who is missing the CLA sign-up?

@Artur-

Artur- commented May 27, 2026

Copy link
Copy Markdown
Member Author

It was claude

@mcollovati
mcollovati enabled auto-merge (squash) May 27, 2026 13:40
@mcollovati
mcollovati merged commit 67a2243 into main May 27, 2026
9 of 10 checks passed
@mcollovati
mcollovati deleted the claude/slack-session-ciPZu branch May 27, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure spotless maven plugin for code formatting

3 participants