refactor: extract @VaadinSessionScoped activation into managed bean (#515) (CP: 15.2)#516
Merged
Merged
Conversation
…#515) Move the activation predicate and storage-access logic out of `VaadinSessionScopedContext` into a nested `ContextualStorageManager` managed bean. The context becomes a thin delegator. As a side effect, applications may replace the bean via CDI `@Specializes` to adjust behavior — though the manager is intentionally undocumented and overriding it is at the integrator's own risk. Adds integration tests covering the strict default and the lenient `@Specializes` scenario from a background thread that does not hold the session lock. References #506
mcollovati
enabled auto-merge (squash)
June 9, 2026 05:43
ZheSun88
approved these changes
Jun 9, 2026
|
This ticket/PR has been released with Vaadin 24.9.18. |
|
This ticket/PR has been released with Vaadin 24.10.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the activation predicate and storage-access logic out of
VaadinSessionScopedContextinto a nestedContextualStorageManagermanaged bean. The context becomes a thin delegator. As a side effect, applications may replace the bean via CDI@Specializesto adjust behavior — though the manager is intentionally undocumented and overriding it is at the integrator's own risk.Adds integration tests covering the strict default and the lenient
@Specializesscenario from a background thread that does not hold the session lock.References #506