[WIP] Trigger validation for 24795#24801
Closed
mcollovati wants to merge 2 commits into
Closed
Conversation
The production-mode token-restore action was added as a Jar.doFirst {}
whose lambda captures the whole Project, which can't be serialized for
the configuration cache. It's moved to the block where the
vaadinBuildFrontendToken service is already in scope, and now captures
that service provider instead of the Project.
Fixes #24794
The config-cache regression in #24794 went unnoticed because the existing configuration-cache tests only run the `vaadinBuildFrontend` task, which never puts a `Jar`/`War` task in the task graph. The faulty token-restore action lived on the packaging task, so the cache never attempted to serialize it. Add a functional test that runs the `war` task with `--configuration-cache` in production mode, exercising the packaging task's `doFirst` action. Against the pre-fix code it reproduces the `cannot serialize object of type 'DefaultProject'` failure; with the fix in place the configuration cache entry is stored and reused. Part of #24794
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.