Skip to content

feat: add SelectItem and SelectListBox components #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZheSun88 merged 1 commit into from
Jul 20, 2026
Merged

feat: add SelectItem and SelectListBox components #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions dev/kitchen-sink/Row8.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
import { BoardRow } from '../../packages/react-components-pro/src/BoardRow.js';
import { Item } from '../../packages/react-components/src/Item.js';
import { ListBox } from '../../packages/react-components/src/ListBox.js';
import { RadioButton } from '../../packages/react-components/src/RadioButton.js';
import { RadioGroup } from '../../packages/react-components/src/RadioGroup.js';
import { RichTextEditor } from '../../packages/react-components-pro/src/RichTextEditor.js';
import { Select } from '../../packages/react-components/src/Select.js';
import { SelectItem } from '../../packages/react-components/src/SelectItem.js';
import { SelectListBox } from '../../packages/react-components/src/SelectListBox.js';
import { Tooltip } from '../../packages/react-components/src/Tooltip.js';

function SelectListBox() {
function SelectRenderer() {
return (
<ListBox>
<Item value="1">One</Item>
<Item value="2">Two</Item>
</ListBox>
<SelectListBox>
<SelectItem value="1">One</SelectItem>
<SelectItem value="2">Two</SelectItem>
</SelectListBox>
);
}

Expand All @@ -29,7 +30,7 @@ export default function Row8() {
</RadioGroup>
<RichTextEditor></RichTextEditor>
<Select label="Select" value="2">
{SelectListBox}
{SelectRenderer}
<span slot="prefix">+</span>
<Tooltip slot="tooltip" text="Select tooltip"></Tooltip>
</Select>
Expand Down
4 changes: 2 additions & 2 deletions dev/pages/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { Select } from '../../packages/react-components/src/Select.js';
import type { SelectItem } from '../../packages/react-components/src/Select.js';
import type { SelectItemData } from '../../packages/react-components/src/Select.js';
import { ListBox } from '../../packages/react-components/src/ListBox.js';
import { Item } from '../../packages/react-components/src/Item.js';
import { Tooltip } from '../../packages/react-components/src/Tooltip.js';
import { useEffect, useState } from 'react';
import type { SelectInvalidChangedEvent, SelectValidatedEvent } from '@vaadin/select';

const items: SelectItem[] = [
const items: SelectItemData[] = [
{ label: 'Option 1', value: 'opt1' },
{ label: 'Option 2', value: 'opt2' },
{ component: 'hr' },
Expand Down
10 changes: 10 additions & 0 deletions packages/react-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,14 @@
"types": "./Select.d.ts",
"default": "./Select.js"
},
"./SelectItem.js": {
"types": "./SelectItem.d.ts",
"default": "./SelectItem.js"
},
"./SelectListBox.js": {
"types": "./SelectListBox.d.ts",
"default": "./SelectListBox.js"
},
"./SideNav.js": {
"types": "./SideNav.d.ts",
"default": "./SideNav.js"
Expand Down Expand Up @@ -507,6 +515,8 @@
"./RangeSlider": "./RangeSlider.js",
"./Scroller": "./Scroller.js",
"./Select": "./Select.js",
"./SelectItem": "./SelectItem.js",
"./SelectListBox": "./SelectListBox.js",
"./SideNav": "./SideNav.js",
"./SideNavItem": "./SideNavItem.js",
"./Slider": "./Slider.js",
Expand Down
1 change: 1 addition & 0 deletions packages/react-components/src/SelectItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './generated/SelectItem.js';
1 change: 1 addition & 0 deletions packages/react-components/src/SelectListBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './generated/SelectListBox.js';
Loading