Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a75978c79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -17,4 +17,3 @@ | |||
| -- atlas:import tables/auth_policies.sql | |||
| -- atlas:import tables/auth_user_agents.sql | |||
| -- atlas:import tables/auth_sessions.sql | |||
There was a problem hiding this comment.
Removing feishu_tokens from schemas/main.sql here does not remove it from real databases, because runtime migration only executes embedded SQL files under internal/db/migrations (internal/db/database.go), and this commit leaves the old 20260321163635_add_feishu_tokens.sql creation migration in place with no matching drop migration. That means fresh installs still create the table and upgraded installs keep deprecated OAuth token rows indefinitely, which is a data-retention/security regression for a feature that was removed.
Useful? React with 👍 / 👎.
Owner
Author
There was a problem hiding this comment.
Added internal/db/migrations/20260328084600_drop_feishu_tokens.sql and refreshed internal/db/migrations/atlas.sum. I also added internal/db/database_test.go to cover both fresh-install and upgrade paths so feishu_tokens is absent after migrations run.
Comment on lines
151
to
153
| if text != "" { | ||
| if handled := b.handleCommand(rc, text, openID, replyFn); handled { | ||
| return nil |
There was a problem hiding this comment.
With the /auth handling block removed, Feishu messages now go through handleCommand and then fall through to normal chat processing when not recognized; since handleCommand only handles shared commands plus /model and /agent, /auth <code> is now treated as ordinary prompt content and sent to the model. Users following old instructions can therefore leak authorization codes into LLM history/provider logs instead of getting a deterministic deprecation response.
Useful? React with 👍 / 👎.
Owner
Author
There was a problem hiding this comment.
Added explicit deprecated /auth handling in internal/channel/feishu/handler.go so Feishu never forwards /auth payloads into normal chat flow, and added TestHandleCommandAuthDeprecated to keep that behavior covered.
📊 Coverage ReportTotal coverage: 44.1% Per-package breakdown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lark-clias optional user-installed workflowcmd/annagateway test expectations with the current no-services error messageValidation