feat(sidebar): group + customize sidebar items, tabbed Settings#216
Open
NovakPAai wants to merge 2 commits into
Open
feat(sidebar): group + customize sidebar items, tabbed Settings#216NovakPAai wants to merge 2 commits into
NovakPAai wants to merge 2 commits into
Conversation
…sses (#209) - Watch ~/.codex/history.jsonl, session_index.jsonl and per-day session dirs in _sessionsNeedRescan so new Codex sessions appear without restarting a long-running codbash server. Walk is performed once per rescan and reused in _updateScanMarkers to avoid a TOCTOU race. - Prefer /proc/<pid>/cwd readlink on Linux; harden lsof fallback with a multiline regex (no leading-newline dependency), strip "(readlink: …)" annotations, and reject /proc/* pseudo-paths. - Drop fallback-latest when cwd is known: emit sessionId='' and _sessionSource='unmatched' instead of confidently misattributing the process to an unrelated latest session. Pick the most recently active session among same-cwd candidates. Frontend now indexes unmatched entries by 'pid:<pid>' so they remain visible on the Agent Board. Accepted lower-severity review notes: - lsof multiline edge cases: -d cwd already constrains output to one FD - mid-walk day-dir deletion: next poll rescans, throw is swallowed - EACCES on ~/.codex: symmetric with other agents' silent skip - stat-on-poll when no Codex installed: one existsSync, negligible
Sidebar is now organized into 3 collapsible sections — Workspace, Agents, Tools — with Install agents as a default-collapsed sub-section. Each entry can be hidden via Settings → Sidebar. Section state and per-item visibility persist in localStorage['codedash-sidebar-config'] (schema v:1). Settings page itself is restructured into 4 sub-tabs: Appearance, Sidebar, Sessions, Integrations. Accessibility: - WAI-ARIA tablist: arrow-key navigation, aria-controls/aria-labelledby. - aria-expanded on section headers; aria-live status region for toggles. - Settings is always visible (UI disabled + model-layer refusal); never lockable from localStorage. - prefers-reduced-motion suppresses chevron transition. - rel="noopener noreferrer" on the external author link. Security: - localStorage payload capped at 64 KB. - __proto__ / constructor / prototype keys explicitly blocked at sanitize. - Config holds only booleans; keys from a hardcoded allow-list; all DOM strings flow through escHtml. No fetch / no network calls added. Tests: 34 node:test cases for pure helpers (parse, serialize, mutators, storage adapters, edge cases) — all green. Spec / BDD / plan / smoke artifacts under docs/design/ specs/ tasks/. Deferred: - tech-debt: cache .sidebar-item NodeList in applySidebarConfig — premature optimization at ~30 elements; profile-driven if it ever shows up. - out-of-scope: count badge on collapsed "Install agents" — cosmetic polish, will land in a follow-up UI PR.
Owner
|
The branch looks like it was forked from git fetch origin
git rebase origin/main
# resolve conflicts (likely in src/frontend/app.js, index.html, styles.css since both PRs touch the sidebar / settings area)
git push --force-with-leaseOnce the diff drops to just the sidebar work ( |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ap-tabsvisual pattern as the Add Project modal.localStorage['codedash-sidebar-config']v:1 +codedash-settings-tab). No server changes, no new endpoints, no network calls.What's new
<div class="sidebar-group" data-section>blocks with<button>headers; nested install-agents sub-groupsrc/frontend/sidebar-config.js(new)parseSidebarConfig/serializeSidebarConfig/isItemHidden/isSectionCollapsed/setItemHidden/setSectionCollapsed/loadFromStorage/saveToStorage/clearStorage/resetConfig+KNOWN_ITEM_KEYSallow-listsrc/frontend/app.jsapplySidebarConfig, section-header click handler,toggleSidebarItem, two-stageonResetSidebarClick,renderSidebarSettingsGroup,onSettingsTabKey(keyboard nav),_announceSidebar(aria-live), tabbedrenderSettingssrc/frontend/styles.css.sidebar-group,.sidebar-section-header(32px min height), chevron rotation,.sidebar-subgroupindent,.settings-sidebar-*rows,.settings-tabs,.sr-onlyindex.htmlcollapsedclass before sidebar markup paints — prevents flash of expanded statetest/sidebar-config.test.js(new)node:testcases — all greenAccessibility
aria-controls,aria-labelledby, rovingtabindex.aria-expandedon section headers;aria-live="polite"status region announces show/hide toggles.disabled,isItemHiddenshort-circuits,setItemHiddenrefuses to write. Three-layer lockout protection.prefers-reduced-motionsuppresses chevron transition.--text-mutedto--text-secondary(WCAG 1.4.3 AA).Security
localStoragepayload capped at 64 KB (synchronous parse on init — DoS guard).__proto__/constructor/prototypekeys explicitly blocked insanitizeMap.<a target="_blank">getrel="noopener noreferrer".Spec-driven artifacts
docs/design/sidebar-customization.md— SDD with full UX/a11y sectionspecs/sidebar-customization.feature— 13 BDD scenarios (happy / empty / loading / error / keyboard / edge)tasks/2026-05-15-sidebar-customization/plan.md— implementation plan + risk register (all 10 risks closed)tasks/2026-05-15-sidebar-customization/smoke-report.md— automated smoke verdictDeferred (tracked in commit message)
.sidebar-itemNodeList inapplySidebarConfig— premature optimization for ~30 elementsTest plan
node --test test/sidebar-config.test.js— 34/34 passlocalStorage['codedash-sidebar-config'] = '{garbage'→ reload → default layout, no error UI#leaderboardwhile Leaderboard hidden → view renders, sidebar link stays hidden