You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This would make the crate nightly only again. I think if we're going to add nightly only features they should be placed behind a feature flag.
A better approach would be criterion but if we're adding that it should be behind a feature flag as somebody importing this likely won't want to download a benchmark crate to build this crate. Also graphs are nice
This would make the crate nightly only again. I think if we're going to add nightly only features they should be placed behind a feature flag.
There's a trick to add benches without making a crate nightly-only, and without needing a feature flag. The benches/ directory is compiled only for cargo bench; if you put all your #[benches] code there, everything else (cargo test, cargo build, everyone who uses your crate as a dependency) keeps working on stable.
And that is exactly what I did. If for instance I use my distro's rustc 1.14.0 (which, of course, has no access to nightly features), cargo build and cargo test still work.
A better approach would be criterion but if we're adding that it should be behind a feature flag as somebody importing this likely won't want to download a benchmark crate to build this crate.
From what I understand, what we have there is just someone suggesting to deprecate benches, not benches being deprecated. But I see no problem using an alternative framework instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.