Support for change aspect ratio mode in OpenGL widget#555
Merged
valbok merged 3 commits intovalbok:masterfrom Mar 2, 2026
Merged
Support for change aspect ratio mode in OpenGL widget#555valbok merged 3 commits intovalbok:masterfrom
valbok merged 3 commits intovalbok:masterfrom
Conversation
valbok
reviewed
Feb 28, 2026
src/QtMultimedia
Outdated
| @@ -0,0 +1 @@ | |||
| /usr/include/qt6/QtMultimedia/6.10.2/QtMultimedia No newline at end of file | |||
Owner
|
Thanks for the contribution, amazing work! |
Contributor
Author
|
It's not much, but I hope it can be of help. |
Owner
|
why closed? |
Contributor
Author
|
I didn't have to close it?, it's my first pull request |
Owner
Thanks and congrats, now you are the contributor https://github.com/valbok/QtAVPlayer/blob/master/CONTRIBUTORS.md |
Contributor
Author
|
Thanks to you ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for the OpenGL widget to change the video's aspect ratio mode, and I also set a black background so that the video doesn't appear transparent when it plays.