Fix configuration window close behavior and preview display issues#6
Open
Devil-Cong wants to merge 3 commits into
Open
Fix configuration window close behavior and preview display issues#6Devil-Cong wants to merge 3 commits into
Devil-Cong wants to merge 3 commits into
Conversation
- Fixed configuration window not closing properly when clicking OK button in System Preferences - Added Preferences menu item in Preview app to reopen configuration window - Fixed font size initialization issue in Preview mode - Fixed motivation level changes not taking effect immediately in Preview mode
… motivation level - Override startAnimation to reload preferences when animation begins - Add defaults synchronization when accessing birthday components - Add defaults synchronization when accessing motivation level - Update birthday information on animation start to reflect current settings - Maintain legacy screen saver compatibility with preference reloading
- Reduced animation frame rate from 30 FPS to 5 FPS - Added comments explaining the performance optimization - Changed animationTimeInterval from 1/30 to 1/5 for better CPU efficiency - Maintained sufficient update frequency for age display with 9 decimal places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes several issues with the configuration window and preview mode:
Fixed Issues
Configuration window not closing properly in System Preferences
endSheet()when displayed in System Preferencesclose()for standalone window modeNo way to reopen configuration window in Preview app
showPreferences:action in AppDelegateFont size display issue on Preview app startup
viewDidMoveToWindow()to ensure font size is calculated after the view has proper boundsMotivation level changes not taking effect immediately
didSetobserver tomotivationLevelproperty to trigger label updateFiles Changed
Motivation/ConfigureSheetController.swiftPreview/AppDelegate.swiftPreview/MainMenu.xibMotivation/AgeView.swiftTesting
Tested on macOS 15.7.3 with both:
All issues are resolved and working as expected.