Rename freeReplyObject to valkeyFreeReplyObject#297
Open
bjosv wants to merge 3 commits intovalkey-io:mainfrom
Open
Rename freeReplyObject to valkeyFreeReplyObject#297bjosv wants to merge 3 commits intovalkey-io:mainfrom
freeReplyObject to valkeyFreeReplyObject#297bjosv wants to merge 3 commits intovalkey-io:mainfrom
Conversation
The old name was inherited from hiredis and conflicts when both libraries are linked into the same binary. Rename to follow the valkey prefix convention used by the rest of the API. This is a breaking API change. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast
reviewed
Apr 30, 2026
Collaborator
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
This function is used by all users so it has a large blast radius, right? Annoying for those who already migrated.
Can we add a define for compatibility?
#define freeReplyObject valkeyFreeReplyObjectYou'd only get it if you include valkey.h so it doesn't conflict for other parts of the system. Maybe also guard it with some ifdef. WDYT?
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Collaborator
|
IMO it's probably worth making this the default behavior when we release v1.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old name was inherited from hiredis and conflicts when both libraries are linked into the same binary.
Rename to follow the valkey prefix convention used by the rest of the API.
This is a breaking API change.
Fixes #288