Refactor parse_cluster_slots and add slot range validation#307
Open
bjosv wants to merge 1 commit intovalkey-io:mainfrom
Open
Refactor parse_cluster_slots and add slot range validation#307bjosv wants to merge 1 commit intovalkey-io:mainfrom
bjosv wants to merge 1 commit intovalkey-io:mainfrom
Conversation
Reject invalid slot ranges (negative, out of bounds, start > end) immediately when parsing the CLUSTER SLOTS reply, rather than letting invalid values propagate through slot creation and node linking until caught later in updateNodesAndSlotmap. Refactored the function to make the validation straightforward: extracted node entry parsing into a helper and flattened the deeply nested inner loop. Added unit test for invalid slot ranges. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure parse_cluster_slots to improve readability and add early validation of slot ranges received from the server.
Changes:
parseClusterSlotsNodeEntryhelper, eliminating duplicated validation logic for primary and replica nodes.