Enforce session-based connection authorization in dispatch loop#411
Merged
Conversation
Signed-off-by: ravjotb <ravjot.brar@improving.com>
ArgusLi
approved these changes
Jul 23, 2026
ravjotbrar
added a commit
that referenced
this pull request
Jul 23, 2026
Signed-off-by: ravjotb <ravjot.brar@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dispatch loop passes ws.sessionId to handlers but never enforces ownership. Since connectionId is deterministic (host-port-dbN), a second user on a shared deployment could send actions with a guessed connectionId and piggyback on another user's authenticated GLIDE client without ever connecting themselves.
Actions targeting a connectionId are rejected unless the requesting session has previously connected to that connection via connectPending. Connection-establishing actions (connectPending, discoveryEndpointPending) bypass the check since they are required for a session to become authorized
Change Visualization
Include a screenshot/video of before and after the change.